From: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Mon, 1 Jul 2013 20:01:04 +0000 (+0200)
Subject: drm/mm: WARN for unclean mm takedown
X-Git-Tag: MMI-PSA29.97-13-9~14059^2~18
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e5ad449be684492f4f58dc169f20926670da7cae;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

drm/mm: WARN for unclean mm takedown

The usual drm driver has tons of different drm_mm memory managers so the drm
error message in dmesg is pretty useless. WARN instead so that we have the full
backtrace.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index e05c3cea322c..543b9b3171d3 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -697,8 +697,8 @@ void drm_mm_takedown(struct drm_mm * mm)
 {
 	struct drm_mm_node *entry, *next;
 
-	if (!list_empty(&mm->head_node.node_list)) {
-		DRM_ERROR("Memory manager not clean. Delaying takedown\n");
+	if (WARN(!list_empty(&mm->head_node.node_list),
+		 "Memory manager not clean. Delaying takedown\n")) {
 		return;
 	}