From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 19 May 2017 21:27:18 +0000 (+0300)
Subject: staging: speakup: signedness bug in spk_ttyio_in_nowait()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e45423d76f1c229b1a30ddde205a72774cdb12c6;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

staging: speakup: signedness bug in spk_ttyio_in_nowait()

On most of the common arches char is signed so it can't ever == 0xff.
Let's fix this by making it a u8.

Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
index 6e0f042f6a44..8ed7c71c712f 100644
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -220,7 +220,7 @@ static unsigned char spk_ttyio_in(void)
 
 static unsigned char spk_ttyio_in_nowait(void)
 {
-	char rv = ttyio_in(0);
+	u8 rv = ttyio_in(0);
 
 	return (rv == 0xff) ? 0 : rv;
 }