From: Dave Hansen <haveblue@us.ibm.com> Date: Mon, 16 Jul 2007 06:41:14 +0000 (-0700) Subject: ext3: remove extra IS_RDONLY() check X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e3a68e30d28dbc6981dfc3d6ceddbfa2f885fe4e;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git ext3: remove extra IS_RDONLY() check ext3_change_inode_journal_flag() is only called from one location: ext3_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 2a85ddee474..de4e3161e47 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c @@ -3195,7 +3195,7 @@ int ext3_change_inode_journal_flag(struct inode *inode, int val) */ journal = EXT3_JOURNAL(inode); - if (is_journal_aborted(journal) || IS_RDONLY(inode)) + if (is_journal_aborted(journal)) return -EROFS; journal_lock_updates(journal);