From: dan.carpenter@oracle.com Date: Sun, 9 Jun 2013 13:07:28 +0000 (+0300) Subject: spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e33d085d11e54bc9fb07b2555cd104d8e7b3089b;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs() '!' has higher precedence than comparisons so the original condition is equivalent to "if (xspi->remaining_bytes == 0)". This makes the static checkers complain. xspi->remaining_bytes is signed and from looking at the code briefly, I think it might be able to go negative. I suspect that going negative may cause a bug, but I don't have the hardware and can't test. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 34d18dcfa0db..109a535b639c 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -315,7 +315,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) } /* See if there is more data to send */ - if (!xspi->remaining_bytes > 0) + if (xspi->remaining_bytes <= 0) break; }