From: Taekki Kim <taekki.kim@samsung.com>
Date: Wed, 31 Oct 2018 11:53:05 +0000 (+0900)
Subject: [RAMEN9610-8100] [COMMON] soc: samsung: bcmdbg: add NULL point when kfree
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e13e4603903669e6352dea0f5c3d3f8bad0a518c;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

[RAMEN9610-8100] [COMMON] soc: samsung: bcmdbg: add NULL point when kfree

Change-Id: Ifb6f5ce6ce03ef3760bd9d24d3ecc840297a5768
Signed-off-by: Taekki Kim <taekki.kim@samsung.com>
---

diff --git a/drivers/soc/samsung/exynos-bcm_dbg.c b/drivers/soc/samsung/exynos-bcm_dbg.c
index 9cbc80b98179..77bf61d5af4f 100644
--- a/drivers/soc/samsung/exynos-bcm_dbg.c
+++ b/drivers/soc/samsung/exynos-bcm_dbg.c
@@ -156,6 +156,11 @@ int exynos_bcm_dbg_ipc_send_data(enum exynos_bcm_dbg_ipc_type ipc_type,
 	int ret;
 	unsigned long flags;
 
+	if (!data) {
+		BCM_ERR("%s: data is not ready!\n", __func__);
+		return -ENODEV;
+	}
+
 	spin_lock_irqsave(&data->lock, flags);
 	ret = __exynos_bcm_dbg_ipc_send_data(ipc_type, data, cmd);
 	spin_unlock_irqrestore(&data->lock, flags);
@@ -1287,6 +1292,12 @@ static int exynos_bcm_dbg_run(unsigned int bcm_run,
 void exynos_bcm_dbg_start(void)
 {
 	int ret;
+
+	if (!bcm_dbg_data) {
+		BCM_ERR("%s: bcm_dbg_data is not ready!\n", __func__);
+		return;
+	}
+
 #ifdef CONFIG_EXYNOS_BCM_DBG_GNR
 	if (!bcm_dbg_data->bcm_load_bin) {
 		ret = exynos_bcm_dbg_load_bin();
@@ -1296,6 +1307,7 @@ void exynos_bcm_dbg_start(void)
 		}
 	}
 #endif
+
 	ret = exynos_bcm_dbg_run(BCM_RUN, bcm_dbg_data);
 	if (ret) {
 		BCM_ERR("%s: failed to bcm start\n", __func__);
@@ -1311,7 +1323,7 @@ void exynos_bcm_dbg_stop(unsigned int bcm_stop_owner)
 	int ret;
 
 	if (!bcm_dbg_data) {
-		BCM_ERR("bcm_dbg_data is not ready!\n");
+		BCM_ERR("%s: bcm_dbg_data is not ready!\n", __func__);
 		return;
 	}
 
@@ -3372,6 +3384,7 @@ static int __init exynos_bcm_dbg_probe(struct platform_device *pdev)
 err_init:
 #endif
 	kfree(data);
+	data = NULL;
 err_data:
 	return ret;
 }
@@ -3392,6 +3405,7 @@ static int exynos_bcm_dbg_remove(struct platform_device *pdev)
 
 	exynos_bcm_dbg_ipc_channel_release(data);
 	kfree(data);
+	data = NULL;
 
 	BCM_INFO("%s: exynos bcm is removed!!\n", __func__);