From: Matthias Schmidt <gravatronics@live.com>
Date: Sat, 29 Jun 2013 22:16:09 +0000 (+0200)
Subject: Fixes JavaScript error after failed package installation AJAX request
X-Git-Tag: 2.0.0_Beta_5~116^2~2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e0a0fe549e45895775ad1b23b738795b9f5f07df;p=GitHub%2FWoltLab%2FWCF.git

Fixes JavaScript error after failed package installation AJAX request

… and adds documentation
---

diff --git a/wcfsetup/install/files/acp/js/WCF.ACP.js b/wcfsetup/install/files/acp/js/WCF.ACP.js
index 948a9df2cf..d484b7cfe3 100644
--- a/wcfsetup/install/files/acp/js/WCF.ACP.js
+++ b/wcfsetup/install/files/acp/js/WCF.ACP.js
@@ -423,7 +423,9 @@ WCF.ACP.Package.Installation = Class.extend({
 	 * Handles erroneous AJAX requests.
 	 */
 	_failure: function() {
-		this._setIcon('remove');
+		if (this._dialog !== null) {
+			this._setIcon('remove');
+		}
 		
 		if (!this._allowRollback) {
 			return;
@@ -679,6 +681,11 @@ WCF.ACP.Package.Installation = Class.extend({
 		this._proxy.sendRequest();
 	},
 	
+	/**
+	 * Sets the icon with the given name as the current installation status icon.
+	 * 
+	 * @param	string		iconName
+	 */
 	_setIcon: function(iconName) {
 		this._dialog.find('.jsPackageInstallationStatus').removeClass('icon-ok icon-question icon-remove icon-spinner').addClass('icon-' + iconName);
 	}