From: Wei Yongjun Date: Fri, 21 Sep 2012 07:19:09 +0000 (+0800) Subject: ARM: pxa: fix return value check in pxa2xx_drv_pcmcia_probe() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e09a716490dbce0b9b7d132d191f1f8785cb5df2;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git ARM: pxa: fix return value check in pxa2xx_drv_pcmcia_probe() In case of error, the function clk_get() returns ERR_PTR() and never returns NULL pointer. The NULL test in the error handling should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Acked-by: Eric Miao Signed-off-by: Haojian Zhuang --- diff --git a/drivers/pcmcia/pxa2xx_base.c b/drivers/pcmcia/pxa2xx_base.c index 490bb82b5bdb..cfec9dd18ff5 100644 --- a/drivers/pcmcia/pxa2xx_base.c +++ b/drivers/pcmcia/pxa2xx_base.c @@ -297,7 +297,7 @@ static int pxa2xx_drv_pcmcia_probe(struct platform_device *dev) } clk = clk_get(&dev->dev, NULL); - if (!clk) + if (IS_ERR(clk)) return -ENODEV; pxa2xx_drv_pcmcia_ops(ops);