From: Bob Copeland Date: Thu, 2 Jun 2016 12:43:50 +0000 (-0400) Subject: ath5k: fix misplaced default label in sifs switch X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=deb85bb1dadf8b4aaa5b33497766dc3f3e4b530e;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git ath5k: fix misplaced default label in sifs switch In this switch statement, the default case does not always assign sifs. In practice, ah->ah_bwmode cannot take values besides the other labels, so this is not an actual problem, but it looks odd and smatch complains thus: ath5k_hw_get_default_sifs() warn: missing break? reassigning 'sifs' Silence the warning by moving default label up a line. Signed-off-by: Bob Copeland Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c index fc47b70988b1..f23c851765df 100644 --- a/drivers/net/wireless/ath/ath5k/pcu.c +++ b/drivers/net/wireless/ath/ath5k/pcu.c @@ -219,8 +219,8 @@ ath5k_hw_get_default_sifs(struct ath5k_hw *ah) sifs = AR5K_INIT_SIFS_QUARTER_RATE; break; case AR5K_BWMODE_DEFAULT: - sifs = AR5K_INIT_SIFS_DEFAULT_BG; default: + sifs = AR5K_INIT_SIFS_DEFAULT_BG; if (channel->band == NL80211_BAND_5GHZ) sifs = AR5K_INIT_SIFS_DEFAULT_A; break;