From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 5 Nov 2014 08:58:11 +0000 (+0900)
Subject: staging: dgap: remove unnecessary function
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=deaa2c2021c2c00401933f84023bfc4c0a60e281;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

staging: dgap: remove unnecessary function

The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 293dc3320b3a..aa393d2941df 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7018,23 +7018,6 @@ static struct pci_driver dgap_driver = {
 	.remove		= dgap_remove_one,
 };
 
-/*
- * dgap_init_globals()
- *
- * This is where we initialize the globals from the static insmod
- * configuration variables.  These are declared near the head of
- * this file.
- */
-static void dgap_init_globals(void)
-{
-	unsigned int i;
-
-	for (i = 0; i < MAXBOARDS; i++)
-		dgap_board[i] = NULL;
-
-	init_timer(&dgap_poll_timer);
-}
-
 /*
  * Start of driver.
  */
@@ -7044,12 +7027,6 @@ static int dgap_start(void)
 	unsigned long flags;
 	struct device *device;
 
-	/*
-	 * make sure that the globals are
-	 * init'd before we do anything else
-	 */
-	dgap_init_globals();
-
 	dgap_numboards = 0;
 
 	pr_info("For the tools package please visit http://www.digi.com\n");