From: Adrian Bunk <bunk@stusta.de>
Date: Mon, 23 Jul 2007 08:02:32 +0000 (+0200)
Subject: drivers/net/acenic.c: fix check-after-use
X-Git-Tag: MMI-PSA29.97-13-9~41167^2~5
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dde9f93c205a791c5647c14d43003c578ebf6f2d;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

drivers/net/acenic.c: fix check-after-use

The Coverity checker noted that we've already dereferenced "dev" when we
check whether it's NULL.

Since it's impossible that "dev" is NULL at this place this patch
removes the NULL check.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index b78a4e5ceeb2..62e660a79387 100644
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -3128,12 +3128,6 @@ static int __devinit read_eeprom_byte(struct net_device *dev,
 	int result = 0;
 	short i;
 
-	if (!dev) {
-		printk(KERN_ERR "No device!\n");
-		result = -ENODEV;
-		goto out;
-	}
-
 	/*
 	 * Don't take interrupts on this CPU will bit banging
 	 * the %#%#@$ I2C device