From: Mantas Mikulėnas Date: Fri, 21 Dec 2018 09:04:26 +0000 (-0800) Subject: Input: synaptics - enable SMBus for HP EliteBook 840 G4 X-Git-Tag: MMI-QSB30.62-17~983^2~44^2~58 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dd707bdce260c0b9adf99e9a3a77a21ca3ead2eb;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git Input: synaptics - enable SMBus for HP EliteBook 840 G4 [ Upstream commit 7a71712293ba303aad928f580b89addb0be2892e ] dmesg reports that "Your touchpad (PNP: SYN3052 SYN0100 SYN0002 PNP0f13) says it can support a different bus." I've tested the offered psmouse.synaptics_intertouch=1 with 4.18.x and 4.19.x and it seems to work well. No problems seen with suspend/resume. Also, it appears that RMI/SMBus mode is actually required for 3-4 finger multitouch gestures to work -- otherwise they are not reported at all. Information from dmesg in both modes: psmouse serio3: synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3139, fw id: 2000742 psmouse serio3: synaptics: Trying to set up SMBus access rmi4_smbus 6-002c: registering SMbus-connected sensor rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3139-001, fw id: 2000742 Signed-off-by: Mantas Mikulėnas Reviewed-by: Benjamin Tissoires Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 515a0b0d48bf..e9ec5d10e0a9 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ "LEN200f", /* T450s */ + "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */ NULL };