From: Marcel Werk <burntime@woltlab.com>
Date: Mon, 11 Apr 2022 09:01:36 +0000 (+0200)
Subject: Create/update page without box information resulted in error
X-Git-Tag: 5.5.0_Alpha_1~19
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dcf3906f440140c48fe2f12861ba048500f7b2bb;p=GitHub%2FWoltLab%2FWCF.git

Create/update page without box information resulted in error
---

diff --git a/wcfsetup/install/files/lib/data/page/PageAction.class.php b/wcfsetup/install/files/lib/data/page/PageAction.class.php
index 954b218654..0393f1f873 100644
--- a/wcfsetup/install/files/lib/data/page/PageAction.class.php
+++ b/wcfsetup/install/files/lib/data/page/PageAction.class.php
@@ -152,11 +152,11 @@ class PageAction extends AbstractDatabaseObjectAction implements ISearchAction,
                     $boxData['visible'],
                 ]);
             }
-        }
 
-        // update box conditions
-        foreach ($this->parameters['boxToPage'] as $boxData) {
-            $this->createPageConditionForBox($boxData['boxID'], [$page]);
+            // update box conditions
+            foreach ($this->parameters['boxToPage'] as $boxData) {
+                $this->createPageConditionForBox($boxData['boxID'], [$page]);
+            }
         }
 
         // save template
@@ -297,11 +297,11 @@ class PageAction extends AbstractDatabaseObjectAction implements ISearchAction,
                     }
                 }
             }
-        }
 
-        // update box conditions
-        foreach ($this->parameters['boxToPage'] as $boxData) {
-            $this->createPageConditionForBox($boxData['boxID'], $this->getObjects());
+            // update box conditions
+            foreach ($this->parameters['boxToPage'] as $boxData) {
+                $this->createPageConditionForBox($boxData['boxID'], $this->getObjects());
+            }
         }
     }