From: Kevin Hilman Date: Tue, 13 Sep 2011 18:18:44 +0000 (-0700) Subject: OMAP3: PM: fix UART handling when using no_console_suspend X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dca2d0eb5917ff132d9be13f0afa9ae5d4e80580;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git OMAP3: PM: fix UART handling when using no_console_suspend During the idle/suspend path, we expect the console lock to be held so that no console output is done during/after the UARTs are idled. However, when using the no_console_suspend argument on the command-line, the console driver does not take the console lock. This allows the possibility of console activity after UARTs have been disabled. To fix, update the current is_suspending() to also check the console_suspend_enabled flag. Reported-by: Abhilash Koyamangalath Tested-by: Abhilash Koyamangalath Signed-off-by: Kevin Hilman --- diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 7255d9bce86..c8cbd00a41a 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -55,7 +55,7 @@ static suspend_state_t suspend_state = PM_SUSPEND_ON; static inline bool is_suspending(void) { - return (suspend_state != PM_SUSPEND_ON); + return (suspend_state != PM_SUSPEND_ON) && console_suspend_enabled; } #else static inline bool is_suspending(void)