From: Wei Yongjun Date: Thu, 20 Sep 2012 21:13:55 +0000 (+0000) Subject: net/irda: sh_sir: fix return value check in sh_sir_set_baudrate() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dc9c9759ebc65d886453c335b2b5be39f87ab01e;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git net/irda: sh_sir: fix return value check in sh_sir_set_baudrate() In case of error, the function clk_get() returns ERR_PTR() and never returns NULL pointer. The NULL test in the error handling should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c index 256eddf1f75a..795109425568 100644 --- a/drivers/net/irda/sh_sir.c +++ b/drivers/net/irda/sh_sir.c @@ -280,7 +280,7 @@ static int sh_sir_set_baudrate(struct sh_sir_self *self, u32 baudrate) } clk = clk_get(NULL, "irda_clk"); - if (!clk) { + if (IS_ERR(clk)) { dev_err(dev, "can not get irda_clk\n"); return -EIO; }