From: Arnd Bergmann Date: Tue, 8 Nov 2016 13:31:38 +0000 (+0100) Subject: net: mii: report 0 for unknown lp_advertising X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dc0b2c9cb47a2176e1f341bfdc770745d24e072c;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git net: mii: report 0 for unknown lp_advertising The newly introduced mii_ethtool_get_link_ksettings function sets lp_advertising to an uninitialized value when BMCR_ANENABLE is not set: drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized] As documented in include/uapi/linux/ethtool.h, the value is expected to be zero when we don't know it, so let's initialize it to that. Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support") Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller --- diff --git a/drivers/net/mii.c b/drivers/net/mii.c index 0443546fc427..6d953c53eed6 100644 --- a/drivers/net/mii.c +++ b/drivers/net/mii.c @@ -213,6 +213,8 @@ int mii_ethtool_get_link_ksettings(struct mii_if_info *mii, SPEED_100 : SPEED_10)); cmd->base.duplex = (bmcr & BMCR_FULLDPLX) ? DUPLEX_FULL : DUPLEX_HALF; + + lp_advertising = 0; } mii->full_duplex = cmd->base.duplex;