From: Tobin C. Harding Date: Wed, 15 Feb 2017 03:27:24 +0000 (+1100) Subject: staging: fbtft: Replace magic number with constant X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=dbc364054c2e2c7008129237cdaa558656de104d;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git staging: fbtft: Replace magic number with constant Current call to strncmp() uses a magic number. There is a compile time constant defined for this buffer, included and used already at other sites in the file. Remove magic number. Replace with pre-existing compile time constant. Signed-off-by: Tobin C. Harding Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 6b9e8adda984..61b7bfc7d714 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -1489,7 +1489,7 @@ static int __init fbtft_device_init(void) } for (i = 0; i < ARRAY_SIZE(displays); i++) { - if (strncmp(name, displays[i].name, 32) == 0) { + if (strncmp(name, displays[i].name, SPI_NAME_SIZE) == 0) { if (displays[i].spi) { spi = displays[i].spi; spi->chip_select = cs;