From: Matthias Schmidt <gravatronics@live.com>
Date: Sat, 24 Nov 2018 14:37:31 +0000 (+0100)
Subject: Fix editing language item via PIP GUI if it has been missing in a language
X-Git-Tag: 5.2.0_Alpha_1~502
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=da4b70dedf69c195eb4eabfcdf68dbdfd54c533a;p=GitHub%2FWoltLab%2FWCF.git

Fix editing language item via PIP GUI if it has been missing in a language

See #2545
---

diff --git a/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php
index e7abe21e86..1837bc08c5 100644
--- a/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php
+++ b/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php
@@ -814,12 +814,13 @@ XML;
 		
 		// replace old element
 		$element = $this->getElementByIdentifier($xml, $identifier);
-		
-		if ($element->parentNode === $newElement->parentNode) {
-			DOMUtil::replaceElement($element, $newElement, false);
-		}
-		else {
-			DOMUtil::removeNode($element);
+		if ($element !== null) {
+			if ($element->parentNode === $newElement->parentNode) {
+				DOMUtil::replaceElement($element, $newElement, false);
+			}
+			else {
+				DOMUtil::removeNode($element);
+			}
 		}
 		
 		return $newElement;