From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 11 Dec 2015 20:24:10 +0000 (+0300)
Subject: nfit: acpi_nfit_notify(): Do not leave device locked
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d91e892825ae6f0ed4f8b07ae5d348eff86ab2ea;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

nfit: acpi_nfit_notify(): Do not leave device locked

Even if dev->driver is null because we are being removed,
it is safer to not leave device locked.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index e7ed39bab97d..aa45d4802707 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1810,7 +1810,7 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event)
 	if (!dev->driver) {
 		/* dev->driver may be null if we're being removed */
 		dev_dbg(dev, "%s: no driver found for dev\n", __func__);
-		return;
+		goto out_unlock;
 	}
 
 	if (!acpi_desc) {