From: Pavel Pisa Date: Tue, 6 Feb 2007 00:10:20 +0000 (-0800) Subject: [ARM] i.MX serial: fix IRQ allocation X-Git-Tag: MMI-PSA29.97-13-9~45074^2~21 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d7ea10d9cbddd49bab282adef805203a36e43101;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git [ARM] i.MX serial: fix IRQ allocation If RTS interrupt is caused by RTS senzing logic inside i.MX UART module the IRQ type cannot be set. It applies only for interrupts going through GPIO layer. The problem has been noticed by Konstantin Kletschke some time ago. No IRQF_TRIGGER set_type function for IRQ 26 (MPU) I would not change type to fixed 0, because it could be possible to use different GPIO MX1 pin for RTS in the theory. On the other hand it is only for documentation purposes now, because RTS read code would have to be adjusted in such case. Signed-off-by: Andrew Morton Signed-off-by: Russell King --- diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c index 03b495c2de14..04cc88cc528c 100644 --- a/drivers/serial/imx.c +++ b/drivers/serial/imx.c @@ -403,7 +403,8 @@ static int imx_startup(struct uart_port *port) if (retval) goto error_out2; retval = request_irq(sport->rtsirq, imx_rtsint, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, + (sport->rtsirq < IMX_IRQS) ? 0 : + IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, DRIVER_NAME, sport); if (retval) goto error_out3;