From: Matthias Schmidt <gravatronics@live.com>
Date: Sun, 24 Feb 2019 13:38:25 +0000 (+0100)
Subject: Only add form field label element if label exists
X-Git-Tag: 5.2.0_Alpha_1~270
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d792e45fe51c2b82258d778b68be8be1f7a4aed5;p=GitHub%2FWoltLab%2FWCF.git

Only add form field label element if label exists

See #2509
---

diff --git a/com.woltlab.wcf/templates/__formFieldHeader.tpl b/com.woltlab.wcf/templates/__formFieldHeader.tpl
index 865a321952..41def24519 100644
--- a/com.woltlab.wcf/templates/__formFieldHeader.tpl
+++ b/com.woltlab.wcf/templates/__formFieldHeader.tpl
@@ -1,3 +1,3 @@
-	<dt><label for="{@$field->getPrefixedId()}">{@$field->getLabel()}</label></dt>
 <dl id="{@$field->getPrefixedId()}Container" {if !$field->getClasses()|empty} class="{implode from=$field->getClasses() item='class' glue=' '}{$class}{/implode}"{/if}{foreach from=$field->getAttributes() key='attributeName' item='attributeValue'} {$attributeName}="{$attributeValue}"{/foreach}{if !$field->checkDependencies()} style="display: none;"{/if}>
+	<dt>{if $field->getLabel() !== null}<label for="{@$field->getPrefixedId()}">{@$field->getLabel()}</label>{/if}</dt>
 	<dd>
diff --git a/wcfsetup/install/files/acp/templates/__formFieldHeader.tpl b/wcfsetup/install/files/acp/templates/__formFieldHeader.tpl
index 865a321952..41def24519 100644
--- a/wcfsetup/install/files/acp/templates/__formFieldHeader.tpl
+++ b/wcfsetup/install/files/acp/templates/__formFieldHeader.tpl
@@ -1,3 +1,3 @@
-	<dt><label for="{@$field->getPrefixedId()}">{@$field->getLabel()}</label></dt>
 <dl id="{@$field->getPrefixedId()}Container" {if !$field->getClasses()|empty} class="{implode from=$field->getClasses() item='class' glue=' '}{$class}{/implode}"{/if}{foreach from=$field->getAttributes() key='attributeName' item='attributeValue'} {$attributeName}="{$attributeValue}"{/foreach}{if !$field->checkDependencies()} style="display: none;"{/if}>
+	<dt>{if $field->getLabel() !== null}<label for="{@$field->getPrefixedId()}">{@$field->getLabel()}</label>{/if}</dt>
 	<dd>