From: Robert Jarzmik Date: Sat, 2 Apr 2016 19:38:53 +0000 (+0200) Subject: kbuild: forbid kernel directory to contain spaces and colons X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d772ec1314f80de536aafc729855bcf3e691f997;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git kbuild: forbid kernel directory to contain spaces and colons commit 51193b76bfff5027cf96ba63effae808ad67cca7 upstream. When the kernel path contains a space or a colon somewhere in the path name, the modules_install target doesn't work anymore, as the path names are not enclosed in double quotes. It is also supposed that and O= build will suffer from the same weakness as modules_install. Instead of checking and improving kbuild to resist to directories including these characters, error out early to prevent any build if the kernel's main directory contains a space. Signed-off-by: Robert Jarzmik Signed-off-by: Michal Marek Signed-off-by: Greg Kroah-Hartman --- diff --git a/Makefile b/Makefile index a50bb7c72b1c..05d83a80464f 100644 --- a/Makefile +++ b/Makefile @@ -128,6 +128,10 @@ _all: # Cancel implicit rules on top Makefile $(CURDIR)/Makefile Makefile: ; +ifneq ($(words $(subst :, ,$(CURDIR))), 1) + $(error main directory cannot contain spaces nor colons) +endif + ifneq ($(KBUILD_OUTPUT),) # Invoke a second make in the output directory, passing relevant variables # check that the output directory actually exists