From: Zhaolei <zhaolei@cn.fujitsu.com>
Date: Mon, 20 Oct 2008 10:53:04 +0000 (+0800)
Subject: USB: Fix debugfs_create_file's error checking method for usb/gadget/s3c2410_udc
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d66937d71a67724870e03fa35af686e7efe85caf;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

USB: Fix debugfs_create_file's error checking method for usb/gadget/s3c2410_udc

debugfs_create_file() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index 48f51b12d2e2..00ba06b44752 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1894,11 +1894,8 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
 		udc->regs_info = debugfs_create_file("registers", S_IRUGO,
 				s3c2410_udc_debugfs_root,
 				udc, &s3c2410_udc_debugfs_fops);
-		if (IS_ERR(udc->regs_info)) {
-			dev_warn(dev, "debugfs file creation failed %ld\n",
-				 PTR_ERR(udc->regs_info));
-			udc->regs_info = NULL;
-		}
+		if (!udc->regs_info)
+			dev_warn(dev, "debugfs file creation failed\n");
 	}
 
 	dev_dbg(dev, "probe ok\n");