From: Alexander Ebert Date: Tue, 26 Jul 2011 16:38:45 +0000 (+0200) Subject: Improved contribution guidelines X-Git-Tag: 2.0.0_Beta_1~1944 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d4f8b3de006d31b2394bcb422bd21e08f715dfe4;p=GitHub%2FWoltLab%2FWCF.git Improved contribution guidelines Using new lines other than Unix-style (\n) is no longer accepted and will cause an immediate reject. Furthermore I've improved details on indentation, causing a lot of confusion lately. --- diff --git a/README.md b/README.md index d7bdd6f71d..adbe0b6ff5 100644 --- a/README.md +++ b/README.md @@ -14,9 +14,11 @@ Contribution Developers are always welcome to fork WCF and provide features or bug fixes using pull requests. If you make changes or add classes it is mandatory to follow the requirements below: * Testing is key, you MUST try out your changes before submitting pull requests -* You SHOULD save your files with Unix-style line endings (\n) +* You MUST save your files with Unix-style line endings (\n) * You MUST NOT include the closing tag of a PHP block at the end of file, provide an empty newline instead -* You MUST use tabs for indentation, we highly recommend a tab size of 8 +* You MUST use tabs for indentation + * Tab size of 8 is required + * Empty lines MUST be indented equal to previous line * All comments within source code MUST be written in English language Follow the above conventions if you want your pull requests accepted.