From: Nicolas Iooss Date: Thu, 16 Apr 2015 19:44:02 +0000 (-0700) Subject: firmware/ihex2fw.c: restore missing default in switch statement X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d43698e8abb58a6ac47d16e0f47bb55f452e4fc4;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git firmware/ihex2fw.c: restore missing default in switch statement Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes the "default:" statement in the switch block, making the "return usage();" line dead code and ihex2fw silently ignoring unknown options. Restore this statement. This bug was found by building with HOSTCC=clang and adding -Wunreachable-code-return to HOSTCFLAGS. Fixes: 2473238eac95 ("ihex: add support for CS:IP/EIP records") Signed-off-by: Nicolas Iooss Cc: Mark Brown Cc: David Woodhouse Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/firmware/ihex2fw.c b/firmware/ihex2fw.c index cf38e159131a..08d90e25abf0 100644 --- a/firmware/ihex2fw.c +++ b/firmware/ihex2fw.c @@ -86,6 +86,7 @@ int main(int argc, char **argv) case 'j': include_jump = 1; break; + default: return usage(); } }