From: Steven Rostedt Date: Thu, 24 Jan 2013 12:52:34 +0000 (-0500) Subject: tracing: Fix unsigned int compare of zero in recursion check X-Git-Tag: MMI-PSA29.97-13-9~15047^2~17^2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d41032a83b4683481cadff84bbf8e0eafeaba830;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git tracing: Fix unsigned int compare of zero in recursion check Dan's smatch found a compare bug with the result of the trace_test_and_set_recursion() and comparing to less than zero. If the function fails, it returns -1, but was saved in an unsigned int, which will never be less than zero and will ignore the result of the test if a recursion did happen. Luckily this is the last of the recursion tests, as the infrastructure of ftrace would catch recursions before it got here, except for some few exceptions. Reported-by: Dan Carpenter Signed-off-by: Steven Rostedt --- diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c index 1c327ef13a9a..601152523326 100644 --- a/kernel/trace/trace_functions.c +++ b/kernel/trace/trace_functions.c @@ -61,7 +61,7 @@ function_trace_call(unsigned long ip, unsigned long parent_ip, struct trace_array *tr = func_trace; struct trace_array_cpu *data; unsigned long flags; - unsigned int bit; + int bit; int cpu; int pc;