From: Ilya Dryomov Date: Mon, 31 Aug 2015 15:22:10 +0000 (+0300) Subject: rbd: plug rbd_dev->header.object_prefix memory leak X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d194cd1dd1be61249b08e5461ae8a9c05d1072c9;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git rbd: plug rbd_dev->header.object_prefix memory leak Need to free object_prefix when rbd_dev_v2_snap_context() fails, but only if this is the first time we are reading in the header. Signed-off-by: Ilya Dryomov Reviewed-by: Alex Elder --- diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 324bf35ec4dd..69d03aa46d0d 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -4720,7 +4720,10 @@ static int rbd_dev_v2_header_info(struct rbd_device *rbd_dev) } ret = rbd_dev_v2_snap_context(rbd_dev); - dout("rbd_dev_v2_snap_context returned %d\n", ret); + if (ret && first_time) { + kfree(rbd_dev->header.object_prefix); + rbd_dev->header.object_prefix = NULL; + } return ret; }