From: Linus Walleij Date: Tue, 13 Sep 2016 12:43:23 +0000 (+0200) Subject: Revert "gpio: pca953x: initialize ret to zero to avoid returning garbage" X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=d147d54899339b321f8319dfb25d05f1eec0e77d;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git Revert "gpio: pca953x: initialize ret to zero to avoid returning garbage" This reverts commit 313b9a9938bf4076425741121d5d766826793e5d. This was already fixed by commit bf62efeb164343916ebb89dca6dfe5e6b6751700 "gpio: pca954x: fix undefined error code from remove" The latter is a better fix since it makes it easier to detect erronous code by not assigning a default error code. Reported-by: Arnd Bergmann Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index f170c5678289..5d059866d17a 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -848,7 +848,7 @@ static int pca953x_remove(struct i2c_client *client) { struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev); struct pca953x_chip *chip = i2c_get_clientdata(client); - int ret = 0; + int ret; if (pdata && pdata->teardown) { ret = pdata->teardown(client, chip->gpio_chip.base,