From: Eric Sesterhenn Date: Thu, 6 Apr 2006 05:28:14 +0000 (-0700) Subject: [BLUETOOTH] sco: Possible double free. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=cdee5751bf91d02616aaf30a5affef56105e3b79;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git [BLUETOOTH] sco: Possible double free. this fixes coverity bug id #1068. hci_send_sco() frees skb if (skb->len > hdev->sco_mtu). Since it returns a negative error value only in this case, we can directly return here. Signed-off-by: Eric Sesterhenn Signed-off-by: David S. Miller --- diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index 6b61323ce23..0c2d13ad69b 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -255,7 +255,7 @@ static inline int sco_send_frame(struct sock *sk, struct msghdr *msg, int len) } if ((err = hci_send_sco(conn->hcon, skb)) < 0) - goto fail; + return err; return count;