From: Wei Yongjun Date: Thu, 31 Oct 2013 07:51:38 +0000 (+0800) Subject: MIPS: ralink: fix return value check in rt_timer_probe() X-Git-Tag: MMI-PSA29.97-13-9~13371^2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=cd5d58108e41b0edecc1e7a6468cbe06ce03be3f;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git MIPS: ralink: fix return value check in rt_timer_probe() In case of error, the function devm_request_and_ioremap() returns NULL pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead of devm_request_and_ioremap(). Signed-off-by: Wei Yongjun Acked-by: John Crispin Cc: grant.likely@linaro.org Cc: rob.herring@calxeda.com Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/6098/ Signed-off-by: Ralf Baechle --- diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c index e49241a2c39a..202785709441 100644 --- a/arch/mips/ralink/timer.c +++ b/arch/mips/ralink/timer.c @@ -126,7 +126,7 @@ static int rt_timer_probe(struct platform_device *pdev) return -ENOENT; } - rt->membase = devm_request_and_ioremap(&pdev->dev, res); + rt->membase = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(rt->membase)) return PTR_ERR(rt->membase);