From: Richard Leitner Date: Fri, 20 May 2016 23:58:33 +0000 (-0700) Subject: mm/memblock.c: remove unnecessary always-true comparison X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=cd33a76b0f2805fb0d6a05a2d53933f3817ccc9b;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git mm/memblock.c: remove unnecessary always-true comparison Comparing an u64 variable to >= 0 returns always true and can therefore be removed. This issue was detected using the -Wtype-limits gcc flag. This patch fixes following type-limits warning: mm/memblock.c: In function `__next_reserved_mem_region': mm/memblock.c:843:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (*idx >= 0 && *idx < type->cnt) { Link: http://lkml.kernel.org/r/20160510103625.3a7f8f32@g0hl1n.net Signed-off-by: Richard Leitner Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/memblock.c b/mm/memblock.c index 3b93daa46fc5..ac1248933b31 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -824,7 +824,7 @@ void __init_memblock __next_reserved_mem_region(u64 *idx, { struct memblock_type *type = &memblock.reserved; - if (*idx >= 0 && *idx < type->cnt) { + if (*idx < type->cnt) { struct memblock_region *r = &type->regions[*idx]; phys_addr_t base = r->base; phys_addr_t size = r->size;