From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 6 Nov 2015 22:56:05 +0000 (+0300)
Subject: sound: fix check for error condition of register_chrdev()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=cb68429d155507ec46f1922d2beb7bc637de4836;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

sound: fix check for error condition of register_chrdev()

init_oss_soundcore() compares returned value of register_chrdev()
with -1, while other error codes can be returned.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/sound_core.c b/sound/sound_core.c
index 11e953a1fa45..99b73c675743 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -655,7 +655,7 @@ static void cleanup_oss_soundcore(void)
 static int __init init_oss_soundcore(void)
 {
 	if (preclaim_oss &&
-	    register_chrdev(SOUND_MAJOR, "sound", &soundcore_fops) == -1) {
+	    register_chrdev(SOUND_MAJOR, "sound", &soundcore_fops) < 0) {
 		printk(KERN_ERR "soundcore: sound device already in use.\n");
 		return -EBUSY;
 	}