From: Gustavo A. R. Silva Date: Wed, 5 Jul 2017 03:09:21 +0000 (-0500) Subject: cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c95a05f9f359c895dc6bd63862923ceba059ef22;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset() Remove unnecessary static on local variable hostbridge. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size. Also, there is a significant difference in the bss segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 5084 3392 256 8732 221c drivers/cpufreq/speedstep-ich.o after: text data bss dec hex filename 5062 3304 192 8558 216e drivers/cpufreq/speedstep-ich.o Signed-off-by: Gustavo A. R. Silva Acked-by: Viresh Kumar Acked-by: Dominik Brodowski Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/cpufreq/speedstep-ich.c b/drivers/cpufreq/speedstep-ich.c index b86953a3ddc4..0412a246a785 100644 --- a/drivers/cpufreq/speedstep-ich.c +++ b/drivers/cpufreq/speedstep-ich.c @@ -207,7 +207,7 @@ static unsigned int speedstep_detect_chipset(void) * 8100 which use a pretty old revision of the 82815 * host bridge. Abort on these systems. */ - static struct pci_dev *hostbridge; + struct pci_dev *hostbridge; hostbridge = pci_get_subsys(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82815_MC,