From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Fri, 26 Feb 2021 14:15:25 +0000 (+0100)
Subject: Reject `packageID = -1` in LanguageEditor::updateFromXML()
X-Git-Tag: 5.4.0_Alpha_1~215^2~2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c7e1ee710bcc69cd8b2072ce8061ed16bea007fe;p=GitHub%2FWoltLab%2FWCF.git

Reject `packageID = -1` in LanguageEditor::updateFromXML()
---

diff --git a/wcfsetup/install/files/lib/data/language/LanguageEditor.class.php b/wcfsetup/install/files/lib/data/language/LanguageEditor.class.php
index e00236cfcd..bb6bc07641 100644
--- a/wcfsetup/install/files/lib/data/language/LanguageEditor.class.php
+++ b/wcfsetup/install/files/lib/data/language/LanguageEditor.class.php
@@ -387,6 +387,10 @@ class LanguageEditor extends DatabaseObjectEditor implements IEditableCachedObje
                     $itemData[] = $itemValue;
                     $itemData[] = $categoryID;
                     if ($packageID) {
+                        if ($packageID == -1) {
+                            throw new \BadMethodCallException('Specifying `-1` as the packageID is no longer supported.');
+                        }
+
                         $itemData[] = ($packageID == -1) ? PACKAGE_ID : $packageID;
                     }