From: hayeswang Date: Thu, 7 Jul 2016 07:09:19 +0000 (+0800) Subject: r8152: remove a netif_carrier_off in rtl8152_open function X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c79262f3f8e06e75e960ff45b48b3c12b2d6b709;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git r8152: remove a netif_carrier_off in rtl8152_open function After commit 90186af404ad ("r8152: fix lockup when runtime PM is enabled"), the autoresume wouldn't start the device before rtl8152_open() is finished. Therefore, we don't have to reset the linking status before and after autoresume. That is, one of netif_carrier_off() in rtl8152_open() could be removed. Signed-off-by: Hayes Wang Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e005ee648efe..f1c502026cae 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -3111,8 +3111,6 @@ static int rtl8152_open(struct net_device *netdev) if (res) goto out; - netif_carrier_off(netdev); - res = usb_autopm_get_interface(tp->intf); if (res < 0) { free_all_mem(tp);