From: Rusty Russell Date: Mon, 19 Jan 2015 22:37:04 +0000 (+1030) Subject: param: fix uninitialized read with CONFIG_DEBUG_LOCK_ALLOC X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c772be52319de9756fd82f36d37a6d3e003441e3;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git param: fix uninitialized read with CONFIG_DEBUG_LOCK_ALLOC ignore_lockdep is uninitialized, and sysfs_attr_init() doesn't initialize it, so memset to 0. Reported-by: Huang Ying Cc: Eric W. Biederman Signed-off-by: Rusty Russell --- diff --git a/kernel/params.c b/kernel/params.c index bd65d136a470..728e05b167de 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -642,6 +642,7 @@ static __modinit int add_sysfs_param(struct module_kobject *mk, mk->mp->grp.attrs = new_attrs; /* Tack new one on the end. */ + memset(&mk->mp->attrs[mk->mp->num], 0, sizeof(mk->mp->attrs[0])); sysfs_attr_init(&mk->mp->attrs[mk->mp->num].mattr.attr); mk->mp->attrs[mk->mp->num].param = kp; mk->mp->attrs[mk->mp->num].mattr.show = param_attr_show;