From: Matthias Schmidt <gravatronics@live.com>
Date: Sun, 12 Jan 2020 16:11:14 +0000 (+0100)
Subject: Do not use html variables in AbstractFormField::getHtml()
X-Git-Tag: 5.2.2~56
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c468b9f9ef3403f3ac6bd123a436069150d9cd29;p=GitHub%2FWoltLab%2FWCF.git

Do not use html variables in AbstractFormField::getHtml()

The additional template variables are only relevant for the actual form field which is generated by `AbstractFormField::getFieldHtml()`.
---

diff --git a/wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php b/wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php
index 6ae7bd7b27..8d3fa693a6 100644
--- a/wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php
+++ b/wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php
@@ -124,9 +124,7 @@ abstract class AbstractFormField implements IFormField {
 		return WCF::getTPL()->fetch(
 			'__formField',
 			'wcf',
-			array_merge($this->getHtmlVariables(), [
-				'field' => $this
-			]),
+			['field' => $this],
 			true
 		);
 	}