From: Al Viro Date: Sun, 8 Apr 2018 15:57:10 +0000 (-0400) Subject: getname_kernel() needs to make sure that ->name != ->iname in long case X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c3efeaa3b15403eb17b693a66c6a297ac459a020;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git getname_kernel() needs to make sure that ->name != ->iname in long case commit 30ce4d1903e1d8a7ccd110860a5eef3c638ed8be upstream. missed it in "kill struct filename.separate" several years ago. Cc: stable@vger.kernel.org Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/namei.c b/fs/namei.c index f839b0750ca3..0b46b858cd42 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -222,9 +222,10 @@ getname_kernel(const char * filename) if (len <= EMBEDDED_NAME_MAX) { result->name = (char *)result->iname; } else if (len <= PATH_MAX) { + const size_t size = offsetof(struct filename, iname[1]); struct filename *tmp; - tmp = kmalloc(sizeof(*tmp), GFP_KERNEL); + tmp = kmalloc(size, GFP_KERNEL); if (unlikely(!tmp)) { __putname(result); return ERR_PTR(-ENOMEM);