From: Vishal Verma Date: Thu, 29 Jun 2017 22:59:11 +0000 (-0600) Subject: libnvdimm, btt: fix btt_rw_page not returning errors X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git libnvdimm, btt: fix btt_rw_page not returning errors btt_rw_page was not propagating errors frm btt_do_bvec, resulting in any IO errors via the rw_page path going unnoticed. the pmem driver recently fixed this in e10624f pmem: fail io-requests to known bad blocks but same problem in BTT went neglected. Fixes: 5212e11fde4d ("nd_btt: atomic sector updates") Cc: Cc: Toshi Kani Cc: Dan Williams Cc: Jeff Moyer Signed-off-by: Vishal Verma Signed-off-by: Dan Williams --- diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 7ca11df80ae8..4e56e720288d 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1248,10 +1248,13 @@ static int btt_rw_page(struct block_device *bdev, sector_t sector, struct page *page, bool is_write) { struct btt *btt = bdev->bd_disk->private_data; + int rc; - btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector); - page_endio(page, is_write, 0); - return 0; + rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector); + if (rc == 0) + page_endio(page, is_write, 0); + + return rc; }