From: Srinivas Pandruvada Date: Thu, 17 Jul 2014 00:42:00 +0000 (+0100) Subject: iio: accel: kxcjk-1013: Increment ref counter for indio_dev->trig X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c1288b8338815d6d17577b6b6a1267e7be8bc409;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git iio: accel: kxcjk-1013: Increment ref counter for indio_dev->trig Assigning indio_dev->trig is not a good idea, as this can result in wrong reference count for trigger device. If assigned, it is better to increment reference counter by calling iio_trigger_get. Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion with Jonathan. Signed-off-by: Srinivas Pandruvada Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index bff5161a36ce..eb8a3229a9d6 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c @@ -644,6 +644,7 @@ static int kxcjk1013_probe(struct i2c_client *client, iio_trigger_set_drvdata(trig, indio_dev); data->trig = trig; indio_dev->trig = trig; + iio_trigger_get(indio_dev->trig); ret = iio_trigger_register(trig); if (ret)