From: Eric Paris Date: Mon, 13 Jul 2009 19:56:55 +0000 (-0400) Subject: fsnotify: fix inotify tail drop check with path entries X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=c05594b62125c528d93af3a78229793aae36df7f;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git fsnotify: fix inotify tail drop check with path entries fsnotify drops new events when they are the same as the tail event on the queue to be sent to userspace. The problem is that if the event comes with a path we forget to break out of the switch statement and fall into the code path which matches on events that do not have any type of file backed information (things like IN_UNMOUNT and IN_Q_OVERFLOW). The problem is that this code thinks all such events should be dropped. Fix is to add a break. Signed-off-by: Eric Paris --- diff --git a/fs/notify/notification.c b/fs/notify/notification.c index 69391fe8efb1..2b20feaf263a 100644 --- a/fs/notify/notification.c +++ b/fs/notify/notification.c @@ -151,6 +151,7 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new if ((old->path.mnt == new->path.mnt) && (old->path.dentry == new->path.dentry)) return true; + break; case (FSNOTIFY_EVENT_NONE): return true; };