From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Mon, 3 Apr 2017 19:22:39 +0000 (-0700)
Subject: xfs: fix kernel memory exposure problems
X-Git-Tag: MMI-PSA29.97-13-9~5868^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=bf9216f922612d2db7666aae01e65064da2ffb3a;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

xfs: fix kernel memory exposure problems

Fix a memory exposure problems in inumbers where we allocate an array of
structures with holes, fail to zero the holes, then blindly copy the
kernel memory contents (junk and all) into userspace.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index 2a6d9b1558e0..26d67ce3c18d 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -583,7 +583,7 @@ xfs_inumbers(
 		return error;
 
 	bcount = MIN(left, (int)(PAGE_SIZE / sizeof(*buffer)));
-	buffer = kmem_alloc(bcount * sizeof(*buffer), KM_SLEEP);
+	buffer = kmem_zalloc(bcount * sizeof(*buffer), KM_SLEEP);
 	do {
 		struct xfs_inobt_rec_incore	r;
 		int				stat;