From: Kees Cook <keescook@chromium.org>
Date: Tue, 8 Apr 2014 04:44:07 +0000 (-0700)
Subject: UBI: avoid workqueue format string leak
X-Git-Tag: MMI-PSA29.97-13-9~12257^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=bebfef150e0b8fa68704cddacf05b8c26462d565;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

UBI: avoid workqueue format string leak

When building the name for the workqueue thread, make sure a format
string cannot leak in from the disk name.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index 7ff473c871a9..8d659e6a1b4c 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -431,7 +431,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 	 * Create one workqueue per volume (per registered block device).
 	 * Rembember workqueues are cheap, they're not threads.
 	 */
-	dev->wq = alloc_workqueue(gd->disk_name, 0, 0);
+	dev->wq = alloc_workqueue("%s", 0, 0, gd->disk_name);
 	if (!dev->wq)
 		goto out_free_queue;
 	INIT_WORK(&dev->work, ubiblock_do_work);