From: Jozsef Kadlecsik Date: Sat, 14 Jan 2012 15:42:13 +0000 (+0100) Subject: netfilter: ipset: dumping error triggered removing references twice X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=be94db9ddac0d6ea76f479b04fb3a43314654c9f;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git netfilter: ipset: dumping error triggered removing references twice If there was a dumping error in the middle, the set-specific variable was not zeroed out and thus the 'done' function of the dumping wrongly tried to release the already released reference of the set. The already released reference was caught by __ip_set_put and triggered a kernel BUG message. Reported by Jean-Philippe Menil. Signed-off-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 0f8e5f2fa1ba..32dbf0fa89db 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -1142,6 +1142,7 @@ release_refcount: if (ret || !cb->args[2]) { pr_debug("release set %s\n", ip_set_list[index]->name); ip_set_put_byindex(index); + cb->args[2] = 0; } out: if (nlh) {