From: Santiago Leon <santil@linux.vnet.ibm.com>
Date: Fri, 3 Sep 2010 18:29:36 +0000 (+0000)
Subject: ibmveth: Return -EINVAL on all ->probe errors
X-Git-Tag: MMI-PSA29.97-13-9~21994^2~548
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=be35ae9e08dbbc70f1cd50de8639627fa501692d;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

ibmveth: Return -EINVAL on all ->probe errors

We had a few cases where we returned success on error.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 8adfff55792d..11086dbe76e8 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1392,7 +1392,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
 							NULL);
 	if (!mac_addr_p) {
 		dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n");
-		return 0;
+		return -EINVAL;
 	}
 
 	mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
@@ -1400,7 +1400,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
 	if (!mcastFilterSize_p) {
 		dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "
 			"attribute\n");
-		return 0;
+		return -EINVAL;
 	}
 
 	netdev = alloc_etherdev(sizeof(struct ibmveth_adapter));