From: Julia Lawall Date: Thu, 13 Dec 2007 23:56:07 +0000 (-0800) Subject: [POWERPC] arch/ppc: Remove an unnecessary pci_dev_put X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=bd4c2edc90c020ba5573da5dbd796fd6ab78692b;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git [POWERPC] arch/ppc: Remove an unnecessary pci_dev_put Remove an unnecessary pci_dev_put. pci_dev_put is called implicitly by the subsequent call to pci_get_device. The problem was detected using the following semantic patch, and corrected by hand. @@ expression dev; expression E; @@ - pci_dev_put(dev) ... when != dev = E - pci_get_device(...,dev) Signed-off-by: Julia Lawall Cc: Benjamin Herrenschmidt Signed-off-by: Andrew Morton Signed-off-by: Paul Mackerras --- diff --git a/arch/ppc/platforms/prep_pci.c b/arch/ppc/platforms/prep_pci.c index 1df3150f016e..8ed433e2a5c7 100644 --- a/arch/ppc/platforms/prep_pci.c +++ b/arch/ppc/platforms/prep_pci.c @@ -1099,7 +1099,6 @@ prep_pib_init(void) pci_write_config_byte(dev, 0x43, reg); } } - pci_dev_put(dev); } if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,