From: H Hartley Sweeten Date: Mon, 7 May 2012 10:31:27 +0000 (+0200) Subject: NFC: HCI ops should not be exposed globally X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=bd007bea21f3a51fc67cbcec412725b2d86f1b27;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git NFC: HCI ops should not be exposed globally The variable 'hci_nfc_ops' is only referenced in this file and should be marked static to prevent it from being exposed globally. Quites the sparse warning: warning: symbol 'hci_nfc_ops' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Cc: Lauro Ramos Venancio Cc: Aloisio Almeida Jr Cc: Samuel Ortiz Cc: "David S. Miller" Signed-off-by: Samuel Ortiz Signed-off-by: John W. Linville --- diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c index f7e4f5ae4559..0fdb96f152b1 100644 --- a/net/nfc/hci/core.c +++ b/net/nfc/hci/core.c @@ -585,7 +585,7 @@ static int hci_check_presence(struct nfc_dev *nfc_dev, return 0; } -struct nfc_ops hci_nfc_ops = { +static struct nfc_ops hci_nfc_ops = { .dev_up = hci_dev_up, .dev_down = hci_dev_down, .start_poll = hci_start_poll,