From: Miguel Boton <mboton@gmail.com>
Date: Sun, 13 Jan 2008 11:03:53 +0000 (+0100)
Subject: [ALSA] fix compilation warning in GCC
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=bc9abce0de0b180817bc7e9f73145ef0b6a464ef;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

[ALSA] fix compilation warning in GCC

'snd_shutdown_f_ops' is not a pointer so its address will never be NULL.
GCC will complain because 'fops_get' will do an unnecessary check because
'&snd_shutdown_f_ops' is always true.

Signed-off-by: Miguel Boton <mboton@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/sound/core/init.c b/sound/core/init.c
index dc06e79ca09f..e3338d6071ef 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -339,8 +339,8 @@ int snd_card_disconnect(struct snd_card *card)
 		list_add(&mfile->shutdown_list, &shutdown_files);
 		spin_unlock(&shutdown_lock);
 
-		fops_get(&snd_shutdown_f_ops);
 		mfile->file->f_op = &snd_shutdown_f_ops;
+		fops_get(mfile->file->f_op);
 		
 		mfile = mfile->next;
 	}