From: Rafał Miłecki <rafal@milecki.pl>
Date: Wed, 17 Aug 2016 13:37:14 +0000 (+0200)
Subject: net: bgmac: fix reversed check for MII registration error
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b9f63ae7ba2de2ba19137c5757c0607ce40f3ed5;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

net: bgmac: fix reversed check for MII registration error

It was failing on successful registration returning meaningless errors.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
index 9a9745c4047c..625235db644f 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -159,7 +159,7 @@ static int bgmac_probe(struct bcma_device *core)
 
 	if (!bgmac_is_bcm4707_family(core)) {
 		mii_bus = bcma_mdio_mii_register(core, bgmac->phyaddr);
-		if (!IS_ERR(mii_bus)) {
+		if (IS_ERR(mii_bus)) {
 			err = PTR_ERR(mii_bus);
 			goto err;
 		}