From: Dan Williams <dan.j.williams@intel.com>
Date: Tue, 17 Jun 2014 23:16:22 +0000 (-0700)
Subject: usb: improve "not suspended yet" message in hub_suspend()
X-Git-Tag: MMI-PSA29.97-13-9~12029^2~4
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b658b8f5c09d3d1db9641c9d520b36b3e4c0d744;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

usb: improve "not suspended yet" message in hub_suspend()

Reading through a recent bug report [1], Alan notes:

  "Dan, the warning message in hub_suspend() should mention that the
   child device isn't suspended yet."

...update the warning from:

  "usb usb3-port4: not suspended yet"

...to:

   "usb usb3-port4: device 3-4: not suspended yet"

[1]: http://marc.info/?l=linux-usb&m=140290586301336&w=2

Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index ec6f05cbbae3..78c3cd20d7ae 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3458,7 +3458,8 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
 		struct usb_device *udev = port_dev->child;
 
 		if (udev && udev->can_submit) {
-			dev_warn(&port_dev->dev, "not suspended yet\n");
+			dev_warn(&port_dev->dev, "device %s not suspended yet\n",
+					dev_name(&udev->dev));
 			if (PMSG_IS_AUTO(msg))
 				return -EBUSY;
 		}