From: Dan Carpenter Date: Thu, 22 Aug 2013 16:07:17 +0000 (-0300) Subject: [media] snd_tea575x: precedence bug in fmr2_tea575x_get_pins() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b5c2e0abe1d0ffc367d0c1a42e45c91c079838d3;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [media] snd_tea575x: precedence bug in fmr2_tea575x_get_pins() The "|" operation has higher precedence that "?:" so this couldn't return both flags set at once as intended. Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c index f1e3714b5f16..620c4907e701 100644 --- a/drivers/media/radio/radio-sf16fmr2.c +++ b/drivers/media/radio/radio-sf16fmr2.c @@ -74,8 +74,8 @@ static u8 fmr2_tea575x_get_pins(struct snd_tea575x *tea) struct fmr2 *fmr2 = tea->private_data; u8 bits = inb(fmr2->io); - return (bits & STR_DATA) ? TEA575X_DATA : 0 | - (bits & STR_MOST) ? TEA575X_MOST : 0; + return ((bits & STR_DATA) ? TEA575X_DATA : 0) | + ((bits & STR_MOST) ? TEA575X_MOST : 0); } static void fmr2_tea575x_set_direction(struct snd_tea575x *tea, bool output)